Add ChatOptions support to ChatAgentConfig#6
Merged
JordanMarr merged 1 commit intoJordanMarr:mainfrom Mar 26, 2026
Merged
Conversation
ChatClientAgent's constructor doesn't accept both instructions/tools and ChatOptions, so this wraps the IChatClient with a delegating client that merges default ChatOptions into every call. Per-call options from MAF override the defaults where present.
Contributor
Author
|
@JordanMarr any love to this? |
Owner
For some reason GitHub just lit up my notification box this morning, so this is the first time I’m even seeing your PR. I’ll check it out. Looks good though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatOptionsfield toChatAgentConfigandChatAgent.withChatOptionspipeline functionIChatClientwith a delegating client that merges defaultChatOptions(temperature, top-p, model, etc.) into every callMotivation
ChatClientAgent's constructor doesn't accept bothinstructions/toolsandChatOptions. This provides a clean way to set options like temperature at the agent config level.Usage